Skip to content

test(storage): control gRPC background thread count#9570

Merged
coryan merged 1 commit intogoogleapis:mainfrom
coryan:test-storage-control-grpc-background-threads
Jul 27, 2022
Merged

test(storage): control gRPC background thread count#9570
coryan merged 1 commit intogoogleapis:mainfrom
coryan:test-storage-control-grpc-background-threads

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Jul 27, 2022 •
edited
Loading

This change is Reviewable

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Jul 27, 2022
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

google-cloud-cpp-bot commented Jul 27, 2022

Google Cloud Build Logs
For commit: 197819ad9982b7c4faccbe2b5ff891eabc8df4dd

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 27, 2022 •
edited
Loading

Codecov Report

Merging #9570 (197819a) into main (f8d1216) will increase coverage by 0.00%.
The diff coverage is 92.30%.

@@           Coverage Diff           @@
##             main    #9570   +/-   ##
=======================================
  Coverage   94.37%   94.37%           
=======================================
  Files        1491     1491           
  Lines      137643   137656   +13     
=======================================
+ Hits       129901   129916   +15     
+ Misses       7742     7740    -2
Impacted Files Coverage Δ
...gle/cloud/storage/benchmarks/throughput_options.cc 85.77% <87.50%> (+0.05%) ⬆️
...loud/storage/benchmarks/throughput_options_test.cc 100.00% <100.00%> (ø)
...e/cloud/spanner/testing/cleanup_stale_instances.cc 72.22% <0.00%> (-5.56%) ⬇️
google/cloud/pubsub/samples/samples.cc 90.77% <0.00%> (+0.07%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 83.00% <0.00%> (+2.00%) ⬆️
...loud/bigtable/internal/connection_refresh_state.cc 98.61% <0.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8d1216...197819a. Read the comment docs.

@coryan coryan marked this pull request as ready for review July 27, 2022 03:24
@coryan coryan requested a review from a team July 27, 2022 03:24
@coryan coryan merged commit 4b06efd into googleapis:main Jul 27, 2022
@coryan coryan deleted the test-storage-control-grpc-background-threads branch July 27, 2022 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@devbww devbww devbww approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coryan @google-cloud-cpp-bot @devbww