feat(common): make the RPC log even more readable#9561
Merged
devbww merged 2 commits intogoogleapis:mainfrom Jul 26, 2022
Merged
feat(common): make the RPC log even more readable#9561devbww merged 2 commits intogoogleapis:mainfrom
devbww merged 2 commits intogoogleapis:mainfrom
Conversation
- Render google.protobuf.Duration and google.protobuf.Timestamp fields as descriptive strings rather than as raw numbers.
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #9561 +/- ##
==========================================
- Coverage 94.37% 94.37% -0.01%
==========================================
Files 1491 1491
Lines 137569 137611 +42
==========================================
+ Hits 129829 129867 +38
- Misses 7740 7744 +4
Continue to review full report at Codecov.
|
`char const (&)[2]`, but allow for its beliefs nevertheless.
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
coryan
approved these changes
Jul 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fields as descriptive strings rather than as raw numbers.
This change is