Skip to content

fix(storage): no char for std::uniform_int_distribution#9509

Merged
coryan merged 1 commit intogoogleapis:mainfrom
coryan:fix-storage-no-char-for-uniform-distribution
Jul 19, 2022
Merged

fix(storage): no char for std::uniform_int_distribution#9509
coryan merged 1 commit intogoogleapis:mainfrom
coryan:fix-storage-no-char-for-uniform-distribution

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Jul 18, 2022 •
edited
Loading

TIL: it is undefined behavior to use std::uniform_int_distribution<>
with char, unsigned char, and its aliases. And some platforms
enforce this.

This change is Reviewable

@coryan
fix(storage): no char for std::uniform_int_distribution
bb2dc79 
TIL: it is undefined behavior to use `std::uniform_int_distribution<>`
with `char`, `unsigned char`, and its aliases. And some platforms
enforce this.
@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Jul 18, 2022
@coryan coryan mentioned this pull request Jul 18, 2022
Merged
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

google-cloud-cpp-bot commented Jul 18, 2022

Google Cloud Build Logs
For commit: bb2dc792a2bfd24f26184be1e601277807006149

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 18, 2022 •
edited
Loading

Codecov Report

Merging #9509 (bb2dc79) into main (ae55c11) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #9509      +/-   ##
==========================================
- Coverage   94.62%   94.62%   -0.01%     
==========================================
  Files        1489     1489              
  Lines      137215   137216       +1     
==========================================
- Hits       129845   129837       -8     
- Misses       7370     7379       +9
Impacted Files Coverage Δ
.../cloud/storage/internal/invocation_id_generator.cc 100.00% <100.00%> (ø)
...e/cloud/spanner/testing/cleanup_stale_instances.cc 72.22% <0.00%> (-5.56%) ⬇️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 97.05% <0.00%> (-2.95%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 87.58% <0.00%> (-1.01%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.82% <0.00%> (-0.68%) ⬇️
google/cloud/internal/curl_impl.cc 91.87% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae55c11...bb2dc79. Read the comment docs.

@coryan coryan marked this pull request as ready for review July 18, 2022 22:20
@coryan coryan requested a review from a team July 18, 2022 22:20
@coryan coryan enabled auto-merge (squash) July 18, 2022 23:56
@coryan coryan merged commit 87523ea into googleapis:main Jul 19, 2022
@coryan coryan deleted the fix-storage-no-char-for-uniform-distribution branch July 19, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbolduc dbolduc dbolduc approved these changes

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coryan @google-cloud-cpp-bot @dbolduc