feat: improve error messages for access token errors#9485
Merged
coryan merged 1 commit intogoogleapis:mainfrom Jul 16, 2022
Merged
feat: improve error messages for access token errors#9485coryan merged 1 commit intogoogleapis:mainfrom
coryan merged 1 commit intogoogleapis:mainfrom
Conversation
When we fail to generate an access token the errors can be very confusing. See for example this discussion: https://issues.apache.org/jira/browse/ARROW-17069 This change is an attempt at making these errors less confusing. They could be made event better if we had a specific webpage describing client library authentication and troubleshooting, but we do not have such a page at the moment.
62b1fe6 to
5e0e930
Compare
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #9485 +/- ##
=======================================
Coverage 94.64% 94.64%
=======================================
Files 1485 1486 +1
Lines 136977 136982 +5
=======================================
+ Hits 129637 129651 +14
+ Misses 7340 7331 -9
Continue to review full report at Codecov.
|
devbww
approved these changes
Jul 15, 2022
Contributor
Author
|
/gcbrun |
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we fail to generate an access token the errors can be very
confusing. See for example this discussion:
https://issues.apache.org/jira/browse/ARROW-17069
This change is an attempt at making these errors less confusing. They
could be made event better if we had a specific webpage describing
client library authentication and troubleshooting, but we do not have
such a page at the moment.
This change is