Skip to content

feat(GCS+gRPC): implement DeleteDefaultObjectAcl()#9473

Merged
coryan merged 1 commit intogoogleapis:mainfrom
coryan:feat-GCS+gRPC-implement-DeleteDefaultObjectAcl
Jul 14, 2022
Merged

feat(GCS+gRPC): implement DeleteDefaultObjectAcl()#9473
coryan merged 1 commit intogoogleapis:mainfrom
coryan:feat-GCS+gRPC-implement-DeleteDefaultObjectAcl

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Jul 14, 2022

Fixes #4184


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 7c07a2274aeeba33ff34556632b4f9365c85ca37

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 14, 2022

Codecov Report

Merging #9473 (7c07a22) into main (2160d58) will increase coverage by 0.00%.
The diff coverage is 97.50%.

@@           Coverage Diff           @@
##             main    #9473   +/-   ##
=======================================
  Coverage   94.63%   94.64%           
=======================================
  Files        1485     1485           
  Lines      136771   136851   +80     
=======================================
+ Hits       129437   129518   +81     
+ Misses       7334     7333    -1     
Impacted Files Coverage Δ
google/cloud/storage/internal/grpc_client_test.cc 98.29% <96.42%> (-0.09%) ⬇️
google/cloud/storage/internal/grpc_client.cc 99.15% <100.00%> (+0.02%) ⬆️
.../tests/grpc_default_object_acl_integration_test.cc 89.79% <100.00%> (+1.42%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 97.98% <0.00%> (+0.16%) ⬆️
...le/cloud/internal/default_completion_queue_impl.cc 97.72% <0.00%> (+0.56%) ⬆️
...torage/examples/storage_service_account_samples.cc 97.64% <0.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2160d58...7c07a22. Read the comment docs.

@coryan coryan marked this pull request as ready for review July 14, 2022 03:23
@coryan coryan requested a review from a team July 14, 2022 03:23
@coryan coryan merged commit a30eb8b into googleapis:main Jul 14, 2022
@coryan coryan deleted the feat-GCS+gRPC-implement-DeleteDefaultObjectAcl branch July 14, 2022 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement storage::GrpcClient::DeleteDefaultObjectAcl

3 participants