feat(run): generate library#9460
Merged
dbolduc merged 4 commits intogoogleapis:mainfrom Jul 13, 2022
Merged
Conversation
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #9460 +/- ##
==========================================
- Coverage 94.63% 94.63% -0.01%
==========================================
Files 1486 1486
Lines 136696 136696
==========================================
- Hits 129369 129364 -5
- Misses 7327 7332 +5
Continue to review full report at Codecov.
|
coryan
approved these changes
Jul 13, 2022
Contributor
|
Linking the functions framework from the README is a great idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9446
The changes to
cmake/CompileProtos.cmakewere required because Cloud Run has ak8s.min.proto. Previously, we would parse the basename as:k8snotk8s.min.Also, we use a custom endpoint name so it doesn't conflict with
google-cloud-cpp/google/cloud/appengine/doc/main.dox
Lines 67 to 69 in 4be7b7e
This change is