Skip to content

feat(pubsub): add new option for exactly-once delivery#9438

Merged
coryan merged 3 commits intogoogleapis:mainfrom
coryan:feat-pubsub-exactly-once-delivery-pr2
Jul 7, 2022
Merged

feat(pubsub): add new option for exactly-once delivery#9438
coryan merged 3 commits intogoogleapis:mainfrom
coryan:feat-pubsub-exactly-once-delivery-pr2

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Jul 6, 2022

Fixes #9327


This change is Reviewable

@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the Pub/Sub API. label Jul 6, 2022
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 916c2c8930d192d3442fbac526a26ff8c90c5f77

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 6, 2022

Codecov Report

Merging #9438 (676a274) into main (a12ed2c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #9438      +/-   ##
==========================================
- Coverage   94.62%   94.62%   -0.01%     
==========================================
  Files        1487     1487              
  Lines      136620   136638      +18     
==========================================
+ Hits       129282   129293      +11     
- Misses       7338     7345       +7     
Impacted Files Coverage Δ
google/cloud/pubsub/internal/defaults.cc 100.00% <100.00%> (ø)
google/cloud/pubsub/internal/defaults_test.cc 100.00% <100.00%> (ø)
...ub/internal/streaming_subscription_batch_source.cc 98.08% <100.00%> (ø)
...le/cloud/storage/internal/curl_download_request.cc 87.54% <0.00%> (-1.02%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.98% <0.00%> (-0.68%) ⬇️
google/cloud/pubsub/samples/samples.cc 92.35% <0.00%> (-0.08%) ⬇️
.../internal/subscription_concurrency_control_test.cc 100.00% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a12ed2c...676a274. Read the comment docs.

@coryan coryan marked this pull request as ready for review July 6, 2022 22:09
@coryan coryan requested a review from a team July 6, 2022 22:09
Comment thread google/cloud/pubsub/internal/defaults_test.cc
Comment thread google/cloud/pubsub/options.h Outdated
Comment thread google/cloud/pubsub/options.h Outdated
Comment thread google/cloud/pubsub/internal/streaming_subscription_batch_source.cc Outdated
@coryan coryan force-pushed the feat-pubsub-exactly-once-delivery-pr2 branch from 916c2c8 to 5ccf82e Compare July 7, 2022 15:24
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 916c2c8930d192d3442fbac526a26ff8c90c5f77

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

Comment thread google/cloud/pubsub/internal/defaults.cc
Comment thread google/cloud/pubsub/internal/defaults.cc Outdated
@coryan coryan force-pushed the feat-pubsub-exactly-once-delivery-pr2 branch from 5ccf82e to 676a274 Compare July 7, 2022 15:49
@coryan coryan enabled auto-merge (squash) July 7, 2022 15:50
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 676a2743e2b12900be33937cf2dc46a2f8196a7e

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit e580800 into googleapis:main Jul 7, 2022
@coryan coryan deleted the feat-pubsub-exactly-once-delivery-pr2 branch July 7, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pub/Sub Exactly Once Delivery

3 participants