Skip to content

Conversation

@coryan
Copy link
Contributor

@coryan coryan commented Jan 8, 2018

Another script that needed fixing after #138.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 8, 2018
@coryan
Copy link
Contributor Author

coryan commented Jan 9, 2018

I forgot to mention, this shows that the script actually works:

https://codecov.io/gh/coryan/google-cloud-cpp/branch/fix-codecov-upload
https://travis-ci.org/coryan/google-cloud-cpp/jobs/326481378#L3798

while the builds at master are failing to upload any data:

https://travis-ci.org/coryan/google-cloud-cpp/jobs/326624014#L3837

Copy link
Contributor

@mbrukman mbrukman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbrukman mbrukman merged commit d3938fd into googleapis:master Jan 9, 2018
@coryan coryan deleted the fix-codecov-upload branch January 9, 2018 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants