Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

chore: check if port is in use before returning the port to start a new server.#394

Merged
harkamaljot merged 2 commits intomainfrom
flaky-tests
Feb 11, 2025
Merged

chore: check if port is in use before returning the port to start a new server.#394
harkamaljot merged 2 commits intomainfrom
flaky-tests

Conversation

@harkamaljot
Copy link
Contributor

Currently OAuthlib has some tests that uses a port to start a local server. Sometimes both tests run using the same port as a result we get errors such as port already in use. Therefore check before returning a port

@harkamaljot harkamaljot requested a review from a team as a code owner February 11, 2025 11:56
@harkamaljot harkamaljot requested a review from a team February 11, 2025 11:56
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 11, 2025
@harkamaljot harkamaljot merged commit 9a1dfab into main Feb 11, 2025
16 checks passed
@harkamaljot harkamaljot deleted the flaky-tests branch February 11, 2025 18:32
@harkamaljot
Copy link
Contributor Author

This didn't help much because the check for is_port_in_use seems to be ineffective as we still see this error.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants