Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

fix: Pass port range from get_user_credentials to find_open_port#212

Merged
clundin25 merged 4 commits intogoogleapis:mainfrom
Viicos:fix-port-range
Aug 15, 2022
Merged

fix: Pass port range from get_user_credentials to find_open_port#212
clundin25 merged 4 commits intogoogleapis:mainfrom
Viicos:fix-port-range

Conversation

@Viicos
Copy link
Copy Markdown
Contributor

@Viicos Viicos commented Jun 16, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #211 🦕

@Viicos Viicos requested a review from a team June 16, 2022 13:21
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jun 16, 2022
@google-cla
Copy link
Copy Markdown

google-cla bot commented Jun 16, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Viicos Viicos changed the title Pass port range from get_user_credentials to find_open_port fix: Pass port range from get_user_credentials to find_open_port Jun 16, 2022
@clundin25 clundin25 requested a review from a team August 15, 2022 21:54
@clundin25 clundin25 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 15, 2022
@clundin25 clundin25 merged commit 479330a into googleapis:main Aug 15, 2022
@clundin25
Copy link
Copy Markdown
Contributor

clundin25 commented Aug 15, 2022

Thanks for the contribution!

@release-please release-please bot mentioned this pull request Aug 15, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@sai-sunder-s sai-sunder-s sai-sunder-s approved these changes

@clundin25 clundin25 clundin25 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Port range not passed from get_user_credentials to find_open_port

4 participants

@Viicos @clundin25 @sai-sunder-s @parthea