chore(python): update release.sh to use keystore #943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source-Link: googleapis/synthtool@69fda12 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ae600f36b6bc972b368367b6f83a1d91ec2c82a4a116b383d67d547c56fe6de3
parthea
approved these changes
Jan 14, 2022
parthea
reviewed
Jan 15, 2022
| import requests.exceptions # pylint: disable=ungrouped-imports | ||
| from requests.packages.urllib3.util.ssl_ import ( | ||
| import six # pylint: disable=ungrouped-imports | ||
| from urllib3.util.ssl_ import ( |
Contributor
There was a problem hiding this comment.
This change to move from requests.packages.urllib3 to urllib3 is required to resolve a mypy failure which started in types-requests==2.27.5. See
python/typeshed#6893
In requests version 2.16.0 and onwards, requests.packages.urllib3 is the same as urllib3
psf/requests#4067
…f83a1d91ec2c82a4a116b383d67d547c56fe6de3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.