Add google.auth.crypt #6

theacodes · 2016-10-04T17:52:04Z

No description provided.

google/auth/_helpers.py

@@ -0,0 +1,65 @@
+# Copyright 2015 Google Inc.


google/auth/crypt.py

+    for start in six.moves.xrange(0, num_bits, 8):
+        curr_bits = bit_list[start:start + 8]
+        char_val = sum(val * digit
+                       for val, digit in zip(_POW2, curr_bits))


google/auth/crypt.py

+        message = _helpers.to_bytes(message, encoding='utf-8')
+        try:
+            return rsa.pkcs1.verify(message, signature, self._pubkey)
+        except (ValueError, rsa.pkcs1.VerificationError):


google/auth/crypt.py

+            ValueError: If the public_key can't be parsed.
+        """
+        public_key = _helpers.to_bytes(public_key)
+        is_x509_cert = b'-----BEGIN CERTIFICATE-----' in public_key


google/auth/crypt.py

+    Returns:
+        bool: True if the signature is valid, otherwise False.
+    """
+    if isinstance(certs, six.binary_type):


tests/test__helpers.py

+
+
+def test_to_bytes_with_nonstring_type():
+    with pytest.raises(ValueError):


tests/test_crypt.py

+from google.auth import crypt
+
+
+DATA_DIR = os.path.join(os.path.dirname(__file__), 'data')


tests/test_crypt.py

+
+    # List of certs
+    assert crypt.verify_signature(
+        to_sign, signature, [OTHER_CERT_BYTES, PUBLIC_CERT_BYTES]) is True


tests/test_crypt.py

+        to_sign, signature, OTHER_CERT_BYTES) is False
+
+
+class TestVerifier:


tox.ini

  sphinx
-commands = sphinx-apidoc --output-dir docs/reference --separate --module-first google
+commands =
+  rm -r docs/reference


tests/test_crypt.py

+
+# To generate privatekey.pem, privatekey.pub, and public_cert.pem:
+#   $ openssl req -new -newkey rsa:1024 -x509 -nodes -out public_cert.pem \
+#       -keyout privatekey.pem


dhermes · 2016-10-04T20:59:07Z

Really great that you added the commands to generate the key files!

theacodes · 2016-10-04T21:02:34Z

@dhermes any outstanding comments?

dhermes · 2016-10-04T21:17:51Z

LGTM

theacodes · 2016-10-04T21:18:52Z

The first module is in!

Add google.auth.crypt

c2e9232

theacodes added this to the 1.0.0 milestone Oct 4, 2016

theacodes assigned bjwatson and dhermes Oct 4, 2016

Remove unused constant

e36467f

dhermes reviewed Oct 4, 2016

View reviewed changes

Jon Wayne Parrott added 5 commits October 4, 2016 11:25

Address review comments

6b69d19

Fix six.string_type -> six.text_type.

3ca610f

Switch to six.moves.zip

632df97

Remove explicit encoding

ac1b7c9

Add datafile generation commands

dea3778

dhermes reviewed Oct 4, 2016

View reviewed changes

tests/test_crypt.py Outdated

# To generate privatekey.pem, privatekey.pub, and public_cert.pem:

# $ openssl req -new -newkey rsa:1024 -x509 -nodes -out public_cert.pem \

# -keyout privatekey.pem

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Add > in command samples.

796f18c

theacodes merged commit 8713a71 into master Oct 4, 2016

theacodes deleted the crypt branch October 4, 2016 21:19

theacodes mentioned this pull request Oct 21, 2016

1.0.0 Roadmap #3

Closed

12 tasks

theacodes unassigned bjwatson and dhermes Oct 11, 2018



		def test_to_bytes_with_nonstring_type():
		with pytest.raises(ValueError):

		from google.auth import crypt


		DATA_DIR = os.path.join(os.path.dirname(__file__), 'data')

		to_sign, signature, OTHER_CERT_BYTES) is False


		class TestVerifier:

Add google.auth.crypt #6

Add google.auth.crypt #6

Uh oh!

Conversation

theacodes commented Oct 4, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Oct 4, 2016

Uh oh!