fix: only add IAM scope to credentials that can change scopes #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-auth-library-python into impersonated-creds-fix
cabb98b to
d245688
Compare
40261be to
ff0aed9
Compare
bshaffer
reviewed
Mar 9, 2020
Contributor
bshaffer
left a comment
There was a problem hiding this comment.
Looks great! One small implementation suggestion is all I have.
Contributor
|
LGTM |
arithmetic1728
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #416.
Users reported that they were no longer able to use user credentials as the parent credential. This was happening because user credentials cannot have their scopes modified after creation.