Skip to content

Add compute engine credentials #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
theacodes merged 3 commits into from
Oct 17, 2016
Merged

Add compute engine credentials #22

theacodes merged 3 commits into from
Oct 17, 2016

Conversation

@theacodes
Copy link
Contributor

@theacodes theacodes commented Oct 14, 2016

No description provided.

@theacodes theacodes added this to the 1.0.0 milestone Oct 14, 2016
@theacodes theacodes force-pushed the compute-credentials branch from a18411f to c0b0484 Compare October 14, 2016 21:32
dhermes
dhermes reviewed Oct 15, 2016
View reviewed changes
google/auth/compute_engine/__init__.py

__all__ = [
'Credentials'
]

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google/auth/compute_engine/__init__.py


__all__ = [
'Credentials'

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google/auth/compute_engine/credentials.py Outdated
# pylint: disable=attribute-defined-outside-init
# (pylint doesn't recognize that this is defined in ScopedCredentials)
self._scopes = _helpers.string_to_scopes(info['scopes'])
# pylint: enable=attribute-defined-outside-init

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tests/compute_engine/test_credentials.py Outdated
from google.auth.compute_engine import credentials


class TestCredentials:

This comment was marked as spam.

Sign in to view

tests/compute_engine/test_credentials.py
class TestCredentials:
@pytest.fixture(autouse=True)
def credentials(self):
self.credentials = credentials.Credentials()

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tests/compute_engine/test_credentials.py Outdated
assert not self.credentials.requires_scopes

def test_create_scoped_fails(self):
pass

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes
dhermes reviewed Oct 16, 2016
View reviewed changes
tests/compute_engine/test_credentials.py
class TestCredentials(object):
@pytest.fixture(autouse=True)
def credentials(self):
self.credentials = credentials.Credentials()

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Oct 16, 2016

LGTM (after resolving the def credentials rename and whatever you decide on __all__)

@theacodes theacodes merged commit a042549 into master Oct 17, 2016
@theacodes theacodes deleted the compute-credentials branch October 17, 2016 17:48
@theacodes theacodes mentioned this pull request Oct 21, 2016
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dhermes dhermes dhermes left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@theacodes @dhermes @bjwatson @elibixby