Add JWT credentials #21

theacodes · 2016-10-14T20:43:22Z

~~(Has #8 as a diffbase)~~

dhermes

I love how test-able this code is

google/auth/jwt.py

+
+    The constructor arguments determine the claims for the JWT that is
+    sent with requests. Usually, you'll construct these credentials with
+    one of the helper constructors.


google/auth/jwt.py

+    Note that JWT credentials will also set the audience claim on demand. If no
+    audience is specified when creating the credentials, then whenever a
+    request is made the credentials will automatically generate a one-time
+    JWT with the request URI as the audience.


google/auth/jwt.py

+        signer = crypt.Signer.from_string(private_key, key_id)
+
+        kwargs.setdefault('subject', email)
+        return cls(signer, issuer=email, **kwargs)


google/auth/jwt.py

+            issuer=issuer if issuer is not None else self._issuer,
+            subject=subject if subject is not None else self._subject,
+            audience=audience if audience is not None else self._audience,
+            additional_claims=dict(self._additional_claims).update(


google/auth/jwt.py

+            'sub': self._subject or self._issuer,
+            'iat': _helpers.datetime_to_secs(now),
+            'exp': _helpers.datetime_to_secs(expiry),
+            'aud': audience or self._audience


tests/test_jwt.py

+    def test_sign_bytes(self):
+        to_sign = b'123'
+        signature = self.credentials.sign_bytes(to_sign)
+        crypt.verify_signature(to_sign, signature, PUBLIC_CERT_BYTES)


tests/test_jwt.py

+        assert not self.credentials.expired
+
+        with mock.patch('google.auth._helpers.utcnow') as now:
+            one_day_from_now = datetime.timedelta(days=1)


tests/test_jwt.py

+            mock.Mock(), 'GET', 'http://example.com?a=1#3', headers)
+
+        header_value = headers['authorization']
+        token = header_value.split().pop()


tests/test_jwt.py

+            None, 'GET', 'http://example.com?a=1#3', headers)
+
+        header_value = headers['authorization']
+        token = header_value.split().pop()


tests/test_jwt.py

+        credentials = self.credentials.with_claims(audience='test')
+        credentials.refresh(None)
+        credentials.before_request(
+            None, 'GET', 'http://example.com?a=1#3', headers)


tests/test_jwt.py

+    SUBJECT = 'subject'
+    AUDIENCE = 'audience'
+    ADDITIONAL_CLAIMS = {'meta': 'data'}
+    credentials = None


tests/test_jwt.py


        header_value = headers['authorization']
-        token = header_value.split().pop()
+        token = header_value.split('Bearer ').pop()


…ct format

dhermes · 2016-10-17T18:02:18Z

LGTM

theacodes added this to the 1.0.0 milestone Oct 14, 2016

theacodes assigned bjwatson and dhermes Oct 14, 2016

Add jwt.Credentials

bf19834

theacodes force-pushed the jwt-credentials branch from 01c1ea8 to bf19834 Compare October 14, 2016 21:09

theacodes changed the title ~~Jwt credentials~~ Add JWT credentials Oct 14, 2016

Jon Wayne Parrott added 2 commits October 15, 2016 12:24

Use io.open and catch keyerrors

39d54d0

Fix docstring

743c4b7

dhermes reviewed Oct 16, 2016

View reviewed changes

Jon Wayne Parrott added 3 commits October 17, 2016 10:16

Address review comments

954056b

Address review comments

da4500a

Slight revision to docstring

f70eeae

dhermes reviewed Oct 17, 2016

View reviewed changes

tests/test_jwt.py

SUBJECT = 'subject'

AUDIENCE = 'audience'

ADDITIONAL_CLAIMS = {'meta': 'data'}

credentials = None

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes reviewed Oct 17, 2016

View reviewed changes

tests/test_jwt.py Outdated

header_value = headers['authorization']

token = header_value.split().pop()

token = header_value.split('Bearer ').pop()

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Use destructuring assignment to ensure header values are in the corre…

cc10022

…ct format

theacodes merged commit abcd3ed into master Oct 17, 2016

theacodes deleted the jwt-credentials branch October 17, 2016 18:23

theacodes mentioned this pull request Oct 21, 2016

1.0.0 Roadmap #3

Closed

12 tasks

theacodes restored the jwt-credentials branch February 22, 2017 23:16

theacodes deleted the jwt-credentials branch February 22, 2017 23:17

theacodes unassigned bjwatson and dhermes Oct 11, 2018

Add JWT credentials #21

Add JWT credentials #21

Uh oh!

Conversation

theacodes commented Oct 14, 2016 • edited by dhermes Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhermes left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Oct 17, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

theacodes commented Oct 14, 2016 •

edited by dhermes

Loading