This repository was archived by the owner on Mar 6, 2026. It is now read-only.
fix: remove sync response logs in AuthorizedSession#1761
Merged
sai-sunder-s merged 1 commit intomainfrom May 21, 2025
Merged
Conversation
7842440 to
29823f8
Compare
parthea
approved these changes
May 12, 2025
sai-sunder-s
approved these changes
May 20, 2025
29823f8 to
5203dfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix: remove sync response logs in AuthorizedSession
END_COMMIT_OVERRIDE
Currently, response logs require decoding response via
response.json()before the actual response is consumed. This results in issues for a streaming API call where the stream is empty due to it being consumed already for logs.Removing the response log from
AuthorizedSessionresolves this issue. We'll still be logging request and response (including the response body) for credentials to satisfy the requirement for client logging.For logging API responses, we need to log the response body within the gapics.