This repository was archived by the owner on Mar 6, 2026. It is now read-only.
fix: read universe_domain for external account authorized user#1450
Merged
arithmetic1728 merged 4 commits intomainfrom Jan 11, 2024
Merged
fix: read universe_domain for external account authorized user#1450arithmetic1728 merged 4 commits intomainfrom
arithmetic1728 merged 4 commits intomainfrom
Conversation
lsirac
approved these changes
Jan 10, 2024
Contributor
lsirac
left a comment
There was a problem hiding this comment.
LGTM, just make sure this doesn't cause any regressions with gcloud given the previous fix we submitted
clundin25
reviewed
Jan 10, 2024
clundin25
approved these changes
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.