This repository was archived by the owner on Mar 6, 2026. It is now read-only.
chore: Add deprecation notice for 3.7.#1371
Merged
gcf-merge-on-green[bot] merged 5 commits intogoogleapis:mainfrom Oct 23, 2023
Merged
chore: Add deprecation notice for 3.7.#1371gcf-merge-on-green[bot] merged 5 commits intogoogleapis:mainfrom
gcf-merge-on-green[bot] merged 5 commits intogoogleapis:mainfrom
Conversation
Contributor
|
it seems some unit test is needed to cover the new changes |
Contributor
Author
Good catch, I'll add those |
d0b056c to
217c01d
Compare
Contributor
|
gcloud will drop 3.7 on sep 26, let's hold on until then |
Contributor
Author
|
@arithmetic1728 sounds good 👍 |
Contributor
Author
|
@arithmetic1728 I am okay with waiting but I think this change is still safe, it is just a deprecation notice that would impact some users |
arithmetic1728
approved these changes
Oct 23, 2023
97d71e8 to
f3ddead
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.