This repository was archived by the owner on Mar 6, 2026. It is now read-only.
fix: Fix IDTokenCredentials update bug#1072
Merged
clundin25 merged 10 commits intogoogleapis:mainfrom Aug 4, 2022
Merged
Conversation
Contributor
|
@mbmccoy could you change the commit message to "fix: Fix IDTokenCredentials update bug" (with a "fix:" prefix) so it can pass the commit message format check? Also could you add a simple unit test for this change? |
The `from_credentials` method should use the specified `target_credentials`.
Contributor
|
Thanks @mbmccoy. I have updated your commit to match our conventional commits style guide. |
Contributor
|
@sai-sunder-s can you take a look as well? |
clundin25
approved these changes
Aug 2, 2022
sai-sunder-s
reviewed
Aug 2, 2022
|
|
||
| assert id_creds.token == ID_TOKEN_DATA | ||
| assert id_creds._include_email is True | ||
| assert id_creds._target_credentials is credentials |
Contributor
There was a problem hiding this comment.
the same creds are used in ln 469 and 471. So there is no point of making the from_credentials call in 471 I think?
Contributor
There was a problem hiding this comment.
Updated with a fix for that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
from_credentialsmethod should use the specifiedtarget_credentials.