Add http.client transport #10

theacodes · 2016-10-06T17:44:06Z

No description provided.

google/auth/transport/_http_client.py

+
+
+class Response(transport.Response):
+    """http.client transport request adapter."""


google/auth/transport/_http_client.py

+            key.lower(): value for key, value in response.getheaders()}
+        self._data = response.read()
+
+    @property


google/auth/transport/_http_client.py

+class Request(transport.Request):
+    """http.client transport request adapter."""
+    def __init__(self):
+        pass


google/auth/transport/_http_client.py

+        Raises:
+            google.auth.exceptions.TransportError: If any exception occurred.
+        """
+        # socket._GLOBAL_DEFAULT_TIMEOUT is the default in http.client.


google/auth/transport/_http_client.py

+        path = urllib.parse.urlunsplit(
+            ('', '', parts.path, parts.query, parts.fragment))
+
+        connection = http_client.HTTPConnection(parts.netloc)


tests/transport/compliance.py

+    def server(self):
+        """Provides a test HTTP server that is automatically created before
+        a test and destroyed at the end. The server is serving a test
+        application that can be used to verify requests."""


tests/transport/compliance.py

+        # pylint: disable=unused-variable
+        # (pylint thinks the flask routes are unusued.)
+        app = flask.Flask(__name__)
+        app.debug = True


tests/transport/compliance.py

+        def index():
+            return 'Basic Content', http_client.OK, {
+                'X-Test-Header': flask.request.headers.get(
+                    'x-test-header', 'value')}


pylintrc

    wrong-import-position,
    no-name-in-module,
    locally-disabled,
+    locally-enabled,


tests/transport/compliance.py

+        # pylint: disable=unused-variable
+        # (pylint thinks the flask routes are unusued.)
+        app = flask.Flask(__name__)
+        app.debug = True


dhermes · 2016-10-07T20:10:07Z

Still remaining:

~~Me understanding what locally-enabled does~~
Raising for non-http schemes in the http_client impl.
Using remove= instead of the None means delete behavior in the query params replace (or another alternative based on our discussion)

theacodes · 2016-10-07T20:45:53Z

Me understanding what locally-enabled does

I think I cleared that up.

Raising for non-http schemes in the http_client impl.

Done.

Using remove= instead of the None means delete behavior in the query params replace (or another alternative based on our discussion)

Does the new examples in the docstring help here? Do you feel strongly that remove should be a separate argument?

dhermes · 2016-10-07T20:49:30Z

Do you feel strongly that remove should be a separate argument?

Yes. Just because Python let's us allow any-old type in doesn't mean it's a good API for users.

Add http.client transport

d77654e

theacodes assigned bjwatson and dhermes Oct 6, 2016

dhermes reviewed Oct 6, 2016

View reviewed changes

Address review comments

03d7d4d

theacodes added this to the 1.0.0 milestone Oct 6, 2016

Address review comments

2a8808c

dhermes reviewed Oct 7, 2016

View reviewed changes

Raise for non-http schemes

7d8748c

Fix lint

6baaa48

theacodes merged commit 0178246 into master Oct 7, 2016

theacodes deleted the http-client-transport branch October 7, 2016 21:05

theacodes mentioned this pull request Oct 21, 2016

1.0.0 Roadmap #3

Closed

12 tasks

theacodes unassigned bjwatson and dhermes Oct 11, 2018

mattmauriello mentioned this pull request Jul 8, 2025

Deeper support for AWS Credential sources #1789

Closed



		class Response(transport.Response):
		"""http.client transport request adapter."""

Add http.client transport #10

Add http.client transport #10

Uh oh!

Conversation

theacodes commented Oct 6, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Oct 7, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theacodes commented Oct 7, 2016

Uh oh!

dhermes commented Oct 7, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

dhermes commented Oct 7, 2016 •

edited

Loading