This repository was archived by the owner on Mar 6, 2026. It is now read-only.
fix: Correct webauthn JSON parsing to be compliant with standard.#1658
Merged
harkamaljot merged 2 commits intogoogleapis:mainfrom Apr 14, 2025
Merged
fix: Correct webauthn JSON parsing to be compliant with standard.#1658harkamaljot merged 2 commits intogoogleapis:mainfrom
harkamaljot merged 2 commits intogoogleapis:mainfrom
Conversation
arithmetic1728
approved these changes
Feb 12, 2025
sai-sunder-s
approved these changes
Feb 24, 2025
079a335 to
d8e1a16
Compare
623a252 to
63e81ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'rpid' -> 'rpId': according to the standard documentation. https://www.w3.org/TR/webauthn-3/#dom-publickeycredentialrequestoptionsjson-rpid