This repository was archived by the owner on Mar 6, 2026. It is now read-only.
feat: Add custom tls signer for ECP Provider.#1402
Merged
clundin25 merged 12 commits intogoogleapis:mainfrom Nov 30, 2023
Merged
feat: Add custom tls signer for ECP Provider.#1402clundin25 merged 12 commits intogoogleapis:mainfrom
clundin25 merged 12 commits intogoogleapis:mainfrom
Conversation
5c1fb0f to
cfff28f
Compare
arithmetic1728
approved these changes
Oct 31, 2023
arithmetic1728
approved these changes
Nov 30, 2023
Contributor
arithmetic1728
left a comment
There was a problem hiding this comment.
LGTM, just some minor comments.
| self._enterprise_cert_file_path.encode("ascii"), | ||
| ): | ||
| raise exceptions.MutualTLSChannelError( | ||
| "failed to configure SSL context" |
Contributor
There was a problem hiding this comment.
maybe update the error message to say which approach was used, something like "failed to configure SSL context using provider lib" / "failed to configure SSL context using offload lib". This will make it easier to identify issues.
Contributor
Author
There was a problem hiding this comment.
Good point, added!
| self._enterprise_cert_file_path = enterprise_cert_file_path | ||
| self._cert = None | ||
| self._sign_callback = None | ||
| self._provider_lib = None |
Contributor
There was a problem hiding this comment.
should we keep the following lines?
self._cert = None
self._sign_callback = None
Contributor
Author
There was a problem hiding this comment.
Oh yes, that was a mistake. I'll add those back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.