This repository was archived by the owner on Nov 20, 2025. It is now read-only.
feat: make both crypto implementations support sign #727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h-library-nodejs into pad-base64-test-crypto
Codecov Report
@@ Coverage Diff @@
## master #727 +/- ##
==========================================
- Coverage 84.69% 84.37% -0.33%
==========================================
Files 18 18
Lines 941 947 +6
Branches 209 209
==========================================
+ Hits 797 799 +2
- Misses 84 88 +4
Partials 60 60
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #727 +/- ##
==========================================
- Coverage 84.69% 84.37% -0.33%
==========================================
Files 18 18
Lines 941 947 +6
Branches 209 209
==========================================
+ Hits 797 799 +2
- Misses 84 88 +4
Partials 60 60
Continue to review full report at Codecov.
|
bcoe
approved these changes
Jun 5, 2019
bcoe
left a comment
There was a problem hiding this comment.
rubber stamp approval, looks reasonable to me.
JustinBeckwith
approved these changes
Jun 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We actually don't really need it for now since the JWT code uses
jws/jwato sign the authentication token, but since I started digging into this, I just decided to make twocryptoimplementations be similar in case if we need it later.