This repository was archived by the owner on Nov 20, 2025. It is now read-only.
fix: pad base64 strings for base64js #722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #722 +/- ##
=========================================
- Coverage 84.78% 84.69% -0.1%
=========================================
Files 18 18
Lines 940 941 +1
Branches 209 209
=========================================
Hits 797 797
- Misses 83 84 +1
Partials 60 60
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #722 +/- ##
=========================================
- Coverage 84.78% 84.69% -0.1%
=========================================
Files 18 18
Lines 940 941 +1
Branches 209 209
=========================================
Hits 797 797
- Misses 83 84 +1
Partials 60 60
Continue to review full report at Codecov.
|
…h-library-nodejs into pad-base64-test-crypto
JustinBeckwith
approved these changes
May 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #716. Also, adding tests for both crypto implementations.