This repository was archived by the owner on Nov 20, 2025. It is now read-only.
fix: throw on missing refresh token in all cases #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #670 +/- ##
=======================================
Coverage 88.29% 88.29%
=======================================
Files 18 18
Lines 769 769
Branches 83 83
=======================================
Hits 679 679
Misses 79 79
Partials 11 11
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #670 +/- ##
=======================================
Coverage 88.29% 88.29%
=======================================
Files 18 18
Lines 769 769
Branches 83 83
=======================================
Hits 679 679
Misses 79 79
Partials 11 11
Continue to review full report at Codecov.
|
alexander-fenster
approved these changes
Apr 15, 2019
Contributor
alexander-fenster
left a comment
There was a problem hiding this comment.
Rubber stamp even though I don't fully understand how it works :(
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #606. In most cases, this library would throw if an attempt to refresh a token was made, and no refresh token was available. It turns out there was a loophole here if the
getRequestHeadersmethod was called, and the throw would get lost in the shuffle. Instead, a call to the OAuth2 refresh endpoint would get made with an empty refresh token, leading to a less awesome exception. This change:describeblock in the test fileMake sure to hide whitespace before reviewing this one :)