This repository was archived by the owner on Nov 20, 2025. It is now read-only.
fix: surface original stack trace and message with errors #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #651 +/- ##
==========================================
- Coverage 88.39% 88.25% -0.15%
==========================================
Files 18 18
Lines 784 783 -1
Branches 86 84 -2
==========================================
- Hits 693 691 -2
- Misses 79 81 +2
+ Partials 12 11 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #651 +/- ##
==========================================
- Coverage 88.26% 88.12% -0.15%
==========================================
Files 18 18
Lines 784 783 -1
Branches 86 84 -2
==========================================
- Hits 692 690 -2
- Misses 80 82 +2
+ Partials 12 11 -1
Continue to review full report at Codecov.
|
callmehiphop
approved these changes
Mar 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #643. This PR looks for multiple instances where context for exceptions could be lost. The two primary types of cases here are:
Instead, we always make sure to re-throw the original error, and consistently pin the original error message to the tail of the new message.