This repository was archived by the owner on Nov 20, 2025. It is now read-only.
fix(deps): upgrade to gcp-metadata v0.9.0#536
Merged
JustinBeckwith merged 7 commits intogoogleapis:nextfrom Dec 20, 2018
JustinBeckwith:meta2
Merged
fix(deps): upgrade to gcp-metadata v0.9.0#536JustinBeckwith merged 7 commits intogoogleapis:nextfrom JustinBeckwith:meta2
JustinBeckwith merged 7 commits intogoogleapis:nextfrom
JustinBeckwith:meta2
Conversation
JustinBeckwith
commented
Nov 19, 2018
package.json
Outdated
| "@types/node": "^10.5.1", | ||
| "@types/pify": "^3.0.2", | ||
| "@types/semver": "^5.5.0", | ||
| "@types/sinon": "^5.0.1", |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@ofrobots gentle ping |
ofrobots
reviewed
Nov 21, 2018
| } | ||
| this.emit('tokens', tokens); | ||
| return {tokens, res}; | ||
| return {tokens, res: null}; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jkwlui
approved these changes
Dec 11, 2018
Contributor
Author
|
OOOk, so here's what I decided to do. There are a few breaking changes brewing for this lib, so I updated the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: In cases where the
Computeclient is used, the thegetRequestHeadersmethod will no longer return anAxiosResponseobject if a request is made to the metadata server. The value of the object will return null. This is not likely to affect any downstream APIs, but is a breaking change nonetheless.