Skip to content
This repository was archived by the owner on Nov 20, 2025. It is now read-only.

fix: Use new auth URIs#434

Merged
theacodes merged 2 commits intomasterfrom
use-new-auth-uris
Jul 31, 2018
Merged

fix: Use new auth URIs#434
theacodes merged 2 commits intomasterfrom
use-new-auth-uris

Conversation

@theacodes
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2018
@codecov-io
Copy link

codecov-io commented Jul 31, 2018

Codecov Report

Merging #434 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #434   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files          15     15           
  Lines         981    981           
  Branches      217    217           
=====================================
  Hits          932    932           
  Misses         49     49
Impacted Files Coverage Δ
src/auth/oauth2client.ts 94.03% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1c2e3d...238664a. Read the comment docs.

Copy link

@crwilcox crwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Though it does seem odd we talk to both googleapis.com and oauth2.googleapis.com?

@theacodes
Copy link
Contributor Author

It's what the spec requests of us, so 🤷‍♀️

@theacodes theacodes changed the title Use new auth URIs fix: Use new auth URIs Jul 31, 2018
@theacodes theacodes merged commit e002108 into master Jul 31, 2018
@theacodes theacodes deleted the use-new-auth-uris branch July 31, 2018 22:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants