Skip to content
This repository was archived by the owner on Nov 20, 2025. It is now read-only.

chore: skip storage sample tests since storage hasn't migrated to 10 *will need to revert*#2032

Merged
sofisl merged 2 commits intomainfrom
sofisl-patch-2
Jun 11, 2025
Merged

chore: skip storage sample tests since storage hasn't migrated to 10 *will need to revert*#2032
sofisl merged 2 commits intomainfrom
sofisl-patch-2

Conversation

@sofisl
Copy link
Contributor

@sofisl sofisl commented Jun 11, 2025

Storage hasn't migrated to auth 10: googleapis/nodejs-storage#2592

I think this is causing these failures https://btx.cloud.google.com/invocations/715b410f-40c1-4bcc-9484-24a9d788092d/targets/cloud-devrel%2Fclient-libraries%2Fnodejs%2Fpresubmit%2Fgoogleapis%2Fgoogle-auth-library-nodejs%2Fnode18%2Fsamples-test/log

I can recreate it locally, running npm ls google-auth-library shows:

npm ls google-auth-library
google-auth-library-samples@ 
├─┬ @google-cloud/language@7.1.0
│ └─┬ google-gax@5.0.1-rc.1
│   └── google-auth-library@10.0.0 deduped -> ./..
├─┬ @google-cloud/storage@7.16.0
│ └── google-auth-library@9.15.1
├─┬ @googleapis/iam@28.0.1
│ └─┬ googleapis-common@8.0.2-rc.0
│   └── google-auth-library@10.0.0 deduped -> ./..
└── google-auth-library@10.0.0 -> ./..

I am going to skip these tests and then release, we do need to get the auth release out to unblock

googleapis/google-api-nodejs-client#3675
googleapis/google-api-nodejs-client#3677
googleapis/google-api-nodejs-client#3681

@sofisl sofisl requested a review from a team June 11, 2025 00:45
@sofisl sofisl requested a review from a team as a code owner June 11, 2025 00:45
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. samples Issues that are directly related to samples. labels Jun 11, 2025
@sofisl sofisl mentioned this pull request Nov 3, 2025
Open
@sofisl sofisl merged commit 5d3f491 into main Jun 11, 2025
19 checks passed
@sofisl sofisl deleted the sofisl-patch-2 branch June 11, 2025 00:54
@sofisl sofisl restored the sofisl-patch-2 branch July 1, 2025 22:04
@sofisl sofisl mentioned this pull request Jul 1, 2025
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@miguelvelezsa miguelvelezsa miguelvelezsa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

samples Issues that are directly related to samples. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sofisl @miguelvelezsa