Skip to content
This repository was archived by the owner on Nov 20, 2025. It is now read-only.

fix: process undefined values before creating URLSearchParams#2029

Merged
sofisl merged 1 commit intomainfrom
fix-process-undefined-values-before-creating-URLSearchParams
Jun 10, 2025
Merged

fix: process undefined values before creating URLSearchParams#2029
sofisl merged 1 commit intomainfrom
fix-process-undefined-values-before-creating-URLSearchParams

Conversation

@miguelvelezsa
Copy link
Contributor

@miguelvelezsa miguelvelezsa commented Jun 10, 2025

Remove undefined fields from object before creating URLSearchParams.

Fixes #2028 and googleapis/google-api-nodejs-client#3681

This fixes a regression introduced in #1938. Basically we are codifying undefined values as strings rather than leaving them empty.

@miguelvelezsa miguelvelezsa requested a review from a team June 10, 2025 20:50
@miguelvelezsa miguelvelezsa requested a review from a team as a code owner June 10, 2025 20:50
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jun 10, 2025
@sofisl sofisl merged commit c0181c5 into main Jun 10, 2025
19 checks passed
@sofisl sofisl deleted the fix-process-undefined-values-before-creating-URLSearchParams branch June 10, 2025 21:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: invalid_grant: code_verifier or verifier is not needed (injected automatically)

2 participants