This repository was archived by the owner on Nov 20, 2025. It is now read-only.
feat: adding configurable token lifespan support#1441
Merged
aeitzman merged 8 commits intogoogleapis:mainfrom Aug 23, 2022
Merged
feat: adding configurable token lifespan support#1441aeitzman merged 8 commits intogoogleapis:mainfrom
aeitzman merged 8 commits intogoogleapis:mainfrom
Conversation
danielbankhead
approved these changes
Aug 19, 2022
Contributor
danielbankhead
left a comment
There was a problem hiding this comment.
Looks good; feel free to merge after the lint issue is resolved.
lsirac
approved these changes
Aug 19, 2022
Contributor
|
Missing doc changes |
lsirac
reviewed
Aug 22, 2022
danielbankhead
approved these changes
Aug 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for configurable token lifespan via the service_account_impersonation object in the ADC. Also adds unit + integration tests.
See go/byoid-sdk-service-account-impersonation-ctl