Skip to content
This repository was archived by the owner on Nov 20, 2025. It is now read-only.

refactor: remove comment and promises, instead only using async/await#1436

Merged
danielbankhead merged 6 commits intogoogleapis:mainfrom
shogo-nakano-desu:refactor/quit-mixing-promises-and-async-await
Aug 19, 2022
Merged

refactor: remove comment and promises, instead only using async/await#1436
danielbankhead merged 6 commits intogoogleapis:mainfrom
shogo-nakano-desu:refactor/quit-mixing-promises-and-async-await

Conversation

@shogo-nakano-desu
Copy link
Copy Markdown
Contributor

@shogo-nakano-desu shogo-nakano-desu commented Aug 3, 2022 •
edited
Loading

Description

  • There is a comment by @bcoe that says TODO here. So I deleted Promises and changed to use async/await only.

Check list

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
    • To be precise, code coverage "rate" in googleauth.ts decreases even though uncovered lines stay the same because lines of code decrease. But I think it is not a problem because actual coverage does not become worse.
  • Appropriate docs were updated (if necessary)
    • Do not need to update in this PR

Refactor #1434 🦕

@shogo-nakano-desu shogo-nakano-desu requested a review from a team as a code owner August 3, 2022 12:09
@shogo-nakano-desu shogo-nakano-desu requested a review from a team August 3, 2022 12:09
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 3, 2022
danielbankhead
danielbankhead approved these changes Aug 18, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@danielbankhead danielbankhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

danielbankhead
danielbankhead approved these changes Aug 18, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@danielbankhead danielbankhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@danielbankhead danielbankhead added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 19, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 19, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2022
@danielbankhead danielbankhead added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 19, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 19, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2022
@danielbankhead danielbankhead merged commit 415108b into googleapis:main Aug 19, 2022
This was referenced Aug 23, 2022
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@danielbankhead danielbankhead danielbankhead approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shogo-nakano-desu @danielbankhead @yoshi-kokoro @d-goog