This repository was archived by the owner on Nov 20, 2025. It is now read-only.
chore!: clean up the Transporter interface.#1407
Merged
sofisl merged 7 commits intogoogleapis:mainfrom Jul 10, 2023
Merged
Conversation
The callback signature doesn't seem to be used.
|
@forty thanks for the contribution, we'll get this triaged soon. |
danielbankhead
approved these changes
Aug 19, 2022
Contributor
danielbankhead
left a comment
There was a problem hiding this comment.
Thanks for your contribution! This looks great. Since the Transporter and BodyResponseCallback<T> interfaces are a part of the public API, this is considered breaking and will roll into the next major release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello (again),
I took the opportunity that I was looking into it to clean up a bit the Transporter interface, as it seems to be used with Promises everywhere in the project.
Fixes #1405