This repository was archived by the owner on Nov 20, 2025. It is now read-only.
feat!: make transporter attribute type more generic#1406
Merged
danielbankhead merged 8 commits intogoogleapis:mainfrom Jul 10, 2023
Merged
feat!: make transporter attribute type more generic#1406danielbankhead merged 8 commits intogoogleapis:mainfrom
danielbankhead merged 8 commits intogoogleapis:mainfrom
Conversation
Contributor
|
As a note - I think this is a worth-while change, but would be backwards-incompatible as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
currently transporter attributes are inferred or explicitly typed as
DefaultTransporter, which is too bad since theTransportertype exist I assume to make room for custom implementation (which I use, but currently I have to either extends DefaultTransporter, or force TS to ignore the typing)