So I actually just recently figured out a workaround that makes it possible to do this with Axios. The issue that I'd refered to was, I think, referring specifically to HTTP proxies; to make HTTPS proxies work, its just a matter of configuring Axios properly. But im not sure; I dont fully understand the difference between HTTP and HTTPS proxies, and how CONNECT fits into it. Ill try to provide as much info as possible, and if thats not enough, Ill ask the person who actually knows; Ive been told that the proxy "uses CONNECT for HTTPS and 'regular HTTP' for HTTP".

Heres the workaround:

First, Im using this library to overwrite the Node HTTP(S) package with a proxied version: https://www.npmjs.com/package/global-tunnel-ng. The code looks something like:

import * as globalTunnel from 'global-tunnel-ng'
globalTunnel.initialize({
  host: '<hostname>',
  port: <port>
})

This works fine with request, but not axios. What Ive done for now to get things to work is the following:

function getGoogleOAuthClient(googleClientId: string, googleSecret: string): OAuth2Client {
    const client = new OAuth2Client(googleClientId, googleSecret)

    // This just gets the native https module "agent" that was modified earlier to use the proxy
    // Dont read too much into the inclusion of "https" - this was an uninformed decision
    const proxyTunnel = getHttpsProxyTunnel()

    if (!proxyTunnel) {
        return client
    }

    // This will tell axios to use the modified https agent. This probably doesnt work for HTTP,
    // but since Google exclusively uses HTTPS it didnt matter. I dont understand *why* it wouldnt work
    // for HTTP, but the linked issue indicated that it wouldnt
    const axiosOptions: AxiosRequestConfig = {
        httpsAgent: getHttpsProxyTunnel(),
        proxy: false
    }

    // Force axios to use the correct httpsAgent
    const origConfigure = client.transporter.configure
    client.transporter.configure = (opts: AxiosRequestConfig) => {
        // You can actually use axios.create(..) to do this, but ofc that wasnt available to me
        opts = origConfigure(opts)
        opts = {...opts, ...axiosOptions}
        return opts
    }

    return client
}

Again, pretty sure this wouldnt work for HTTP, based on what I've read in the linked Github issue. And since this workaround does actually work, then for my needs personally, I dont actually need request, since this is perfectly hackable with axios (or, ideally, a way to set these options in the google-auth-library itself without the hacky thing that Ive done).

That being said, its possible that someone out there needs to also support HTTP, in which case it might still make sense to consider request even though thats not longer my particular issue.

Thank you!

Add support for proxies #352

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions