This repository was archived by the owner on Nov 20, 2025. It is now read-only.
feat: Normalize GoogleAuth<T> from JSONClient to AuthClient#1940
Merged
feat: Normalize GoogleAuth<T> from JSONClient to AuthClient#1940
GoogleAuth<T> from JSONClient to AuthClient#1940Conversation
GoogleAuth<AuthClient>GoogleAuth<T> from JSONClient to AuthClient
…js into normalize-googleauth-authclient
sofisl
reviewed
Jun 4, 2025
Contributor
sofisl
left a comment
There was a problem hiding this comment.
Since it's breaking, should this wait until Node 20? We can close this PR and create a next major bug for it.
Contributor
Author
I think we should include it in this major since we added it before the cutoff and it resolves a long-open pain-point for customers. |
Contributor
|
If you can confirm it will be a no-op for already released packages (gapics, handwrittens, and apiary), then I'm ok with it. Otherwise since we've already released these as majors I don't think it'll be wise to add another breaking change. |
sofisl
approved these changes
Jun 12, 2025
Contributor
|
I checked this does not create a breaking change with downstream libraries. |
GoogleAuth<T> from JSONClient to AuthClientGoogleAuth<T> from JSONClient to AuthClient
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve a long-open pain-point for customers by setting the default AuthClient generic in GoogleAuth to
AuthClient:GoogleAuth<T>toAuthClient#1677This improves the default compatibly between
GoogleAuthinstances as they would all be compatible by default (givenAuthClientis the base type of allAuthClients)Impact
A few things:
GoogleAuthclientOptions, making it easier for customers to see options for all auth clients:Testing
This is mostly a TypeScript-level change; non-functional. However, I've added a simple test to ensure compatibility.
Additional Information
The
clientOptionsfield could be improved by the following:As it would be nice to if we could use the constructor of
Tto narrow the options to justT's constructor options.Fixes #1677
🦕