Skip to content
This repository was archived by the owner on Nov 20, 2025. It is now read-only.

refactor!: remove additionalOptions from AuthClients#1689

Merged
d-goog merged 10 commits intogoogleapis:mainfrom
Dhoni77:chore/refactor-additionalOptions
Feb 5, 2025
Merged

refactor!: remove additionalOptions from AuthClients#1689
d-goog merged 10 commits intogoogleapis:mainfrom
Dhoni77:chore/refactor-additionalOptions

Conversation

@Dhoni77
Copy link
Contributor

@Dhoni77 Dhoni77 commented Nov 7, 2023

Fixes #1672 🦕

  • Remove additionalOptions from clients and quotaProjectId param from DownScopedClient

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Nov 7, 2023
@danielbankhead danielbankhead changed the title refactor: remove additionalOptions from AuthClients refactor!: remove additionalOptions from AuthClients Nov 7, 2023
@danielbankhead danielbankhead added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 7, 2023
Copy link
Contributor

@danielbankhead danielbankhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Dhoni77 Dhoni77 marked this pull request as ready for review November 9, 2023 10:17
@Dhoni77 Dhoni77 requested a review from a team as a code owner November 9, 2023 10:17
@Dhoni77 Dhoni77 requested a review from a team November 9, 2023 10:17
@Dhoni77 Dhoni77 changed the title refactor!: remove additionalOptions from AuthClients refactor: remove additionalOptions from AuthClients Nov 9, 2023
@danielbankhead danielbankhead changed the title refactor: remove additionalOptions from AuthClients refactor!: remove additionalOptions from AuthClients Nov 10, 2023
@danielbankhead danielbankhead added the next major: breaking change this is a change that we should wait to bundle into the next major version label Nov 15, 2023
@d-goog d-goog removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 1, 2025
@d-goog d-goog requested a review from a team as a code owner February 4, 2025 19:44
@d-goog d-goog merged commit 2f780a8 into googleapis:main Feb 5, 2025
11 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

next major: breaking change this is a change that we should wait to bundle into the next major version size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor!: @deprecate additionalOptions from AuthClients

3 participants