This repository was archived by the owner on Nov 20, 2025. It is now read-only.
fix: Validate url domain for aws metadata urls#1484
Merged
alexander-fenster merged 4 commits intogoogleapis:mainfrom Nov 3, 2022
Merged
fix: Validate url domain for aws metadata urls#1484alexander-fenster merged 4 commits intogoogleapis:mainfrom
alexander-fenster merged 4 commits intogoogleapis:mainfrom
Conversation
lsirac
reviewed
Nov 1, 2022
lsirac
reviewed
Nov 1, 2022
lsirac
approved these changes
Nov 3, 2022
alexander-fenster
approved these changes
Nov 3, 2022
alexander-fenster
approved these changes
Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating AWS credential source validation as per new updates in AIP. Make sure the host of url, region_url and imdsv2 session token url belong to AWS metadata server.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕