Skip to content
This repository was archived by the owner on Nov 20, 2025. It is now read-only.

fix: Validate url domain for aws metadata urls#1484

Merged
alexander-fenster merged 4 commits intogoogleapis:mainfrom
sai-sunder-s:awsurls
Nov 3, 2022
Merged

fix: Validate url domain for aws metadata urls#1484
alexander-fenster merged 4 commits intogoogleapis:mainfrom
sai-sunder-s:awsurls

Conversation

@sai-sunder-s
Copy link
Copy Markdown
Contributor

@sai-sunder-s sai-sunder-s commented Nov 1, 2022

Updating AWS credential source validation as per new updates in AIP. Make sure the host of url, region_url and imdsv2 session token url belong to AWS metadata server.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 1, 2022
@sai-sunder-s sai-sunder-s marked this pull request as ready for review November 1, 2022 04:04
@sai-sunder-s sai-sunder-s requested a review from a team as a code owner November 1, 2022 04:04
@sai-sunder-s sai-sunder-s requested a review from a team November 1, 2022 04:04
@alexander-fenster alexander-fenster added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 3, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 3, 2022
@alexander-fenster alexander-fenster merged commit 6dc4e58 into googleapis:main Nov 3, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants