This repository was archived by the owner on Nov 20, 2025. It is now read-only.
feat: Introduce environment variable for quota project#1478
Merged
sai-sunder-s merged 8 commits intogoogleapis:mainfrom Nov 4, 2022
Merged
feat: Introduce environment variable for quota project#1478sai-sunder-s merged 8 commits intogoogleapis:mainfrom
sai-sunder-s merged 8 commits intogoogleapis:mainfrom
Conversation
alexander-fenster
approved these changes
Oct 24, 2022
Contributor
alexander-fenster
left a comment
There was a problem hiding this comment.
LGTM with some comments. Please wait for Daniel's review before submitting.
Contributor
danielbankhead
left a comment
There was a problem hiding this comment.
Looks good, a few more things to consider after further review
ef31f19 to
3e69699
Compare
Contributor
danielbankhead
left a comment
There was a problem hiding this comment.
Looks good; just need 1 more test.
4d7e5d7 to
786f566
Compare
danielbankhead
approved these changes
Nov 4, 2022
Contributor
danielbankhead
left a comment
There was a problem hiding this comment.
Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕