Skip to content

HttpRequest.__init__ remove useless mimeparse#467

Merged
theacodes merged 1 commit into
googleapis:masterfrom
xmedeko:http_init
Jan 19, 2018
Merged

HttpRequest.__init__ remove useless mimeparse#467
theacodes merged 1 commit into
googleapis:masterfrom
xmedeko:http_init

Conversation

@xmedeko

@xmedeko xmedeko commented Jan 17, 2018

Copy link
Copy Markdown
Contributor

Fix #284

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 17, 2018
@theacodes

Copy link
Copy Markdown
Contributor

@xmedeko this might be useful, can you add a test that demonstrates the case?

@xmedeko

xmedeko commented Jan 17, 2018

Copy link
Copy Markdown
Contributor Author

A test code is in the #284. Do you mean a test into the test_http.py?

@theacodes

theacodes commented Jan 17, 2018 via email

Copy link
Copy Markdown
Contributor

@xmedeko

xmedeko commented Jan 19, 2018

Copy link
Copy Markdown
Contributor Author

Added a simple test of HttpRequest.__init__ by amend.
Note: the mimeparse.parse_mime_type is not used and may be removed?
Note2: http.py has some unused imports: base64, gzip, sys

@theacodes theacodes merged commit b86bfc9 into googleapis:master Jan 19, 2018
@theacodes

Copy link
Copy Markdown
Contributor

Thanks, @xmedeko

@xmedeko xmedeko deleted the http_init branch January 19, 2018 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants