build: add describe.py to scripts folder to fix failing Github Action #2125
Conversation
vchudnov-g
left a comment
There was a problem hiding this comment.
Thank you for finding the workaround, but I am disturbed that it was working before and then suddenly stopped working. Did a path change? Or did a pip install like this one not run as it used to, or fail? It makes me uncomfortable to fix this blindly without knowing why it broke.
Aside from that, and another question about coverage, blocking on one change: symlink describe.py so we don't change the surface.
…om/googleapis/google-api-python-client into move-describe-py-to-scripts-folder
…om/googleapis/google-api-python-client into move-describe-py-to-scripts-folder
vchudnov-g
left a comment
There was a problem hiding this comment.
One question about DISCOVERY_DOC_DIR in the script.
And still wondering what made this stop working all of a sudden.
I was unable to reproduce the original issue outside of Github Actions. It seems to me that something changed in the Github Actions environment which caused this action to fail. The changes in this PR seem to resolve the issue. |
|
OK. We need to ensure there is (and we pay attention to) proactive communication about breakages like this. It's not good to be taken by surprise. |
The Github Action that is used to update the cache of discovery artifacts recently started failing with error
ModuleNotFoundError: No module named 'describe'without any code changes in this repo. See build log here.Through testing in #2124, I found that moving the
describe.pymodule to thescriptsfolder solved the issue. This module is only used by the GitHub action and is not part ofgoogleapiclient.Below is the specific line that was failing in the GitHub action:
google-api-python-client/scripts/updatediscoveryartifacts.py
Line 23 in 84530bd