Skip to content

docs: fix a typo in UPGRADING.md related to static_discovery#1956

Merged
parthea merged 3 commits intomainfrom
parthea-patch-3
Oct 27, 2022
Merged

docs: fix a typo in UPGRADING.md related to static_discovery#1956
parthea merged 3 commits intomainfrom
parthea-patch-3

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented Oct 25, 2022 •
edited
Loading

See the code below

google-api-python-client/googleapiclient/discovery.py

Lines 270 to 274 in cb89554

if static_discovery is None:
if discoveryServiceUrl is None:
static_discovery = True
else:
static_discovery = False

This PR proposes that we change the wording in UPGRADING.md from

if `static_discovery` is not
specified, the default value for `static_discovery` will be `True` when
the `discoveryServiceUrl` argument of `discovery.build()` is provided.

to

if `static_discovery` is not
specified, the default value for `static_discovery` will be `False` when
the `discoveryServiceUrl` argument of `discovery.build()` is provided.

@parthea parthea requested a review from a team as a code owner October 25, 2022 15:11
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 25, 2022
@parthea parthea merged commit bc03ac6 into main Oct 27, 2022
@parthea parthea deleted the parthea-patch-3 branch October 27, 2022 19:31
@release-please release-please bot mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dandhlee dandhlee dandhlee approved these changes

Assignees

No one assigned

Labels

size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@parthea @dandhlee