Skip to content

docs: remove http from batch execute docs #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 2 commits into from
Sep 1, 2020
Merged

docs: remove http from batch execute docs #1003

gcf-merge-on-green merged 2 commits into from
Sep 1, 2020

Conversation

@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Aug 12, 2020

http=http is optional

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1002 🦕

@busunkim96
docs: remove http from execute
3074862 
`http=http` is optional
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2020
@busunkim96 busunkim96 requested a review from plamut August 12, 2020 16:34
plamut
plamut approved these changes Sep 1, 2020
View reviewed changes
Copy link

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there's no http to pass in.

@plamut plamut added the automerge Merge the pull request once unit tests and other checks pass. label Sep 1, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 5028fe7 into master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@plamut plamut plamut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Issues with batch readme example

2 participants

@busunkim96 @plamut