Skip to content

docs(samples): Replace APPENGINE_RUNTIME with GAE_ENV#1893

Merged
parthea merged 2 commits intogoogleapis:mainfrom
abotero:gae_api
Aug 30, 2022
Merged

docs(samples): Replace APPENGINE_RUNTIME with GAE_ENV#1893
parthea merged 2 commits intogoogleapis:mainfrom
abotero:gae_api

Conversation

@abotero
Copy link
Copy Markdown
Contributor

@abotero abotero commented Aug 29, 2022

GAE_ENV is available in gen1 and gen2 runtimes.

Signed-off-by: Andres Botero botero@google.com

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Replace APPENGINE_RUNTIME with GAE_ENV.
631b7c3 
GAE_ENV is available in gen1 and gen2 runtimes.

Signed-off-by: Andres Botero <botero@google.com>
@abotero abotero requested a review from a team August 29, 2022 17:23
@google-cla
Copy link
Copy Markdown

google-cla bot commented Aug 29, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Aug 29, 2022
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 30, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 30, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 30, 2022
@parthea parthea changed the title Replace APPENGINE_RUNTIME with GAE_ENV. docs(samples): Replace APPENGINE_RUNTIME with GAE_ENV Aug 30, 2022
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 30, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 30, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 30, 2022
@parthea parthea merged commit af3160d into googleapis:main Aug 30, 2022
@parthea
Copy link
Copy Markdown
Contributor

parthea commented Aug 30, 2022

Thanks @abotero!

This was referenced Aug 30, 2022
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthea parthea parthea approved these changes

Assignees

No one assigned

Labels

size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abotero @parthea @yoshi-kokoro