Skip to content

fix(deps): pin @types/prettier to v2.6.0#3093

Merged
gcf-merge-on-green[bot] merged 1 commit intomainfrom
alexander-fenster-patch-1
Oct 25, 2022
Merged

fix(deps): pin @types/prettier to v2.6.0#3093
gcf-merge-on-green[bot] merged 1 commit intomainfrom
alexander-fenster-patch-1

Conversation

@alexander-fenster
Copy link
Copy Markdown
Contributor

Fixes this:

../../../node_modules/@types/prettier/index.d.ts:41:54 - error TS2315: Type 'IsTuple' is not generic.

41 type IndexProperties<T extends { length: number }> = IsTuple<T> extends true
                                                        ~~~~~~~~~~

../../../node_modules/@types/prettier/index.d.ts:53:6 - error TS2456: Type alias 'IsTuple' circularly references itself.

53 type IsTuple<T> = T extends [] ? true : T extends [infer First, ...infer Remain] ? IsTuple<Remain> : false;
        ~~~~~~~

I will close the Renovate PR when it comes to avoid it bumping this dependency again.

Fixes this:

```
../../../node_modules/@types/prettier/index.d.ts:41:54 - error TS2315: Type 'IsTuple' is not generic.

41 type IndexProperties<T extends { length: number }> = IsTuple<T> extends true
                                                        ~~~~~~~~~~

../../../node_modules/@types/prettier/index.d.ts:53:6 - error TS2456: Type alias 'IsTuple' circularly references itself.

53 type IsTuple<T> = T extends [] ? true : T extends [infer First, ...infer Remain] ? IsTuple<Remain> : false;
        ~~~~~~~
```

I will close the Renovate PR when it comes to avoid it bumping this dependency again.
@alexander-fenster alexander-fenster requested a review from a team October 25, 2022 21:21
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 25, 2022
@alexander-fenster alexander-fenster added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit f6e9441 into main Oct 25, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the alexander-fenster-patch-1 branch October 25, 2022 21:50
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 25, 2022
@release-please release-please bot mentioned this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants