Skip to content

chore: remove owlbot#2508

Merged
JoeWang1127 merged 1 commit intomainfrom
chore/remove-owlbot
Aug 28, 2024
Merged

chore: remove owlbot#2508
JoeWang1127 merged 1 commit intomainfrom
chore/remove-owlbot

Conversation

@JoeWang1127
Copy link
Copy Markdown
Contributor

@JoeWang1127 JoeWang1127 commented Aug 28, 2024 •
edited
Loading

In this PR:

  • Disable Owlbot and remove related files, please see go/disable-owlbot-java for more info.

@generated-files-bot
Copy link
Copy Markdown

generated-files-bot bot commented Aug 28, 2024

Warning: This pull request is touching the following templated files:

  • .github/generated-files-bot.yml
  • codecov.yaml

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Aug 28, 2024
@JoeWang1127
Copy link
Copy Markdown
Contributor Author

JoeWang1127 commented Aug 28, 2024

CodeQL / Analyze (python) failed due to deletion of owlbot.py.

  /opt/hostedtoolcache/CodeQL/2.18.2/x64/codeql/codeql database finalize --finalize-dataset --threads=4 --ram=14567 /home/runner/work/_temp/codeql_databases/python
  CodeQL detected code written in Java/Kotlin, but not any written in Python. Confirm that there is some source code for Python in the project. For more information, review our troubleshooting guide at https://gh.io/troubleshooting-code-scanning/no-source-code-seen-during-build .
  Error: Encountered a fatal error while running "/opt/hostedtoolcache/CodeQL/2.18.2/x64/codeql/codeql database finalize --finalize-dataset --threads=4 --ram=14567 /home/runner/work/_temp/codeql_databases/python". Exit code was 32 and last log line was: CodeQL detected code written in Java/Kotlin, but not any written in Python. Confirm that there is some source code for Python in the project. For more information, review our troubleshooting guide at https://gh.io/troubleshooting-code-scanning/no-source-code-seen-during-build . See the logs for more details.

@JoeWang1127 JoeWang1127 marked this pull request as ready for review August 28, 2024 19:40
@JoeWang1127 JoeWang1127 requested review from a team and diegomarquezp August 28, 2024 19:40
@diegomarquezp
Copy link
Copy Markdown
Contributor

diegomarquezp commented Aug 28, 2024

LGTM. I think we need to disable the CodeQL analyzer in the repo settings, since it's only configured to scan python code.

image

@diegomarquezp
Copy link
Copy Markdown
Contributor

diegomarquezp commented Aug 28, 2024

Can you add a quick description on what is this PR meant to address?

@JoeWang1127 JoeWang1127 merged commit dd33337 into main Aug 28, 2024
@JoeWang1127 JoeWang1127 deleted the chore/remove-owlbot branch August 28, 2024 22:28
@diegomarquezp diegomarquezp mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegomarquezp diegomarquezp diegomarquezp approved these changes

Assignees

No one assigned

Labels

size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoeWang1127 @diegomarquezp