chore(gensupport): merge x-goog-api-client vals into a single header#2612
Merged
Conversation
quartzmo
requested changes
Jun 5, 2024
quartzmo
left a comment
Member
There was a problem hiding this comment.
Can you expand TestSendRequestHeader (or add a new test) to cover this change?
tritone
approved these changes
Jun 7, 2024
tritone
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good; thanks for adding the test.
| for _, v := range vals { | ||
| req.Header.Add(k, v) | ||
| if k != "x-goog-api-client" { | ||
| for _, v := range vals { |
Contributor
There was a problem hiding this comment.
nit: could you flip this conditional? Seems more readable to have the default case as the "else".
quartzmo
approved these changes
Jun 7, 2024
shollyman
approved these changes
Jun 7, 2024
tritone
approved these changes
Jun 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.