feat(auth): support manual PRM override by duwenxin99 · Pull Request #2717 · googleapis/mcp-toolbox

duwenxin99 · 2026-03-11T19:27:29Z

Add flag to allow manual PRM override.

gemini-code-assist · 2026-03-11T19:28:54Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the authentication capabilities by introducing the option to provide a manual Protected Resource Metadata (PRM) file. This allows for greater flexibility and control over the PRM configuration, enabling users to define custom metadata instead of relying solely on the auto-generated version.

Highlights

Manual PRM File Support: Introduced a new command-line flag --mcp-prm-file to allow users to specify a path to a custom Protected Resource Metadata (PRM) JSON file, overriding the default auto-generation.
PRM Handler Logic Update: Modified the prmHandler to prioritize serving the content of the manually provided PRM file if the --mcp-prm-file flag is set, otherwise falling back to the existing auto-generation logic.
Configuration and Server Integration: Updated the server configuration and Server struct to store the path to the manual PRM file, ensuring it's accessible when handling PRM requests.
Comprehensive Testing: Added a new test case to verify the correct behavior of the PRM endpoint when a manual PRM file is provided, ensuring the system correctly reads and serves its content.

Changelog

cmd/root.go
- Added a new --mcp-prm-file flag for specifying a manual PRM JSON file.
internal/server/config.go
- Added McpPrmFile field to ServerConfig struct to hold the path to the manual PRM file.
internal/server/mcp.go
- Imported the os package.
- Updated the mcpRouter condition to enable the PRM endpoint if a manual PRM file is specified.
- Modified prmHandler to read and serve the content of the manual PRM file if s.mcpPrmFile is set, otherwise proceeding with auto-generation.
internal/server/mcp_test.go
- Added TestPRMEndpoint_ManualFile to test the PRM endpoint's behavior when a manual PRM file is provided.
internal/server/server.go
- Added mcpPrmFile field to the Server struct.
- Initialized the mcpPrmFile field in NewServer from the ServerConfig.

Activity

No human activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a useful feature to allow overriding the auto-generated Protected Resource Metadata (PRM) with a manually provided JSON file. The implementation is straightforward, adding a new command-line flag and handling the file serving logic in the prmHandler. The changes are well-tested with a new unit test covering the happy path.

I have one suggestion to improve the robustness of this feature by adding validation for the provided JSON file.

github-actions · 2026-03-11T19:49:19Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2717/

github-actions · 2026-03-11T21:17:05Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2717/

github-actions · 2026-03-20T19:25:51Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2717/

github-actions · 2026-03-23T22:12:28Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2717/

github-actions · 2026-03-25T21:59:45Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2717/

github-actions · 2026-03-25T22:10:28Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2717/

github-actions · 2026-03-26T19:40:47Z

🚀 Cloudflare Preview Ready!

🔎 View Preview: https://pr-2717.toolbox-docs-6xc.pages.dev

(Note: Subsequent pushes to this PR will automatically update the preview at this same URL)

github-actions · 2026-03-26T19:41:09Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2717/

github-actions · 2026-03-26T20:05:21Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2717/

github-actions · 2026-03-26T20:31:29Z

🧨 Preview deployments removed.

github-actions · 2026-03-26T20:32:15Z

🧨 Preview deployments removed.

Cloudflare Pages environments for pr-2717 have been deleted.

Add flag to allow manual PRM override. 283e4e3

🤖 I have created a release *beep* *boop* --- ## [0.31.0](v0.30.0...v0.31.0) (2026-03-26) ### ⚠ BREAKING CHANGES * release upgraded docsite ([#2831](#2831)) * **http:** sanitize non-2xx error output ([#2654](#2654)) * add a new `enable-api` flag ([#2846](#2846)) * remove deprecations and update tools-file flag ([#2806](#2806)) ### Features * Add a new `enable-api` flag ([#2846](#2846)) ([7a070da](7a070da)) * **auth:** Add generic `authService` type for MCP ([#2619](#2619)) ([f6678f8](f6678f8)) * **auth:** Add Protected Resource Metadata endpoint ([#2698](#2698)) ([b53dcf2](b53dcf2)) * **auth:** Support manual PRM override ([#2717](#2717)) ([283e4e3](283e4e3)) * **dataplex:** Add support for lookup context tool. ([#2744](#2744)) ([facb69d](facb69d)) * Remove deprecations and update tools-file flag ([#2806](#2806)) ([ab64c95](ab64c95)) ### Bug Fixes * **ci:** Remove search index generation from preview deployment workflow ([#2859](#2859)) ([f8891b8](f8891b8)) * **docs:** Skip empty folders in pagination & reduce PR comment noise ([#2853](#2853)) ([9ebd93a](9ebd93a)) * **http:** Sanitize non-2xx error output ([#2654](#2654)) ([5bef954](5bef954)) * **skills:** Fix integer parameter parsing through agent skills ([#2847](#2847)) ([4564efe](4564efe)) ### Documentation * Release upgraded docsite ([#2831](#2831)) ([5b25ce0](5b25ce0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [0.31.0](v0.30.0...v0.31.0) (2026-03-26) ### ⚠ BREAKING CHANGES * release upgraded docsite ([#2831](#2831)) * **http:** sanitize non-2xx error output ([#2654](#2654)) * add a new `enable-api` flag ([#2846](#2846)) * remove deprecations and update tools-file flag ([#2806](#2806)) ### Features * Add a new `enable-api` flag ([#2846](#2846)) ([7a070da](7a070da)) * **auth:** Add generic `authService` type for MCP ([#2619](#2619)) ([f6678f8](f6678f8)) * **auth:** Add Protected Resource Metadata endpoint ([#2698](#2698)) ([b53dcf2](b53dcf2)) * **auth:** Support manual PRM override ([#2717](#2717)) ([283e4e3](283e4e3)) * **dataplex:** Add support for lookup context tool. ([#2744](#2744)) ([facb69d](facb69d)) * Remove deprecations and update tools-file flag ([#2806](#2806)) ([ab64c95](ab64c95)) ### Bug Fixes * **ci:** Remove search index generation from preview deployment workflow ([#2859](#2859)) ([f8891b8](f8891b8)) * **docs:** Skip empty folders in pagination & reduce PR comment noise ([#2853](#2853)) ([9ebd93a](9ebd93a)) * **http:** Sanitize non-2xx error output ([#2654](#2654)) ([5bef954](5bef954)) * **skills:** Fix integer parameter parsing through agent skills ([#2847](#2847)) ([4564efe](4564efe)) ### Documentation * Release upgraded docsite ([#2831](#2831)) ([5b25ce0](5b25ce0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> c6b811c

🤖 I have created a release *beep* *boop* --- ## [0.31.0](googleapis/mcp-toolbox@v0.30.0...v0.31.0) (2026-03-26) ### ⚠ BREAKING CHANGES * release upgraded docsite ([googleapis#2831](googleapis#2831)) * **http:** sanitize non-2xx error output ([googleapis#2654](googleapis#2654)) * add a new `enable-api` flag ([googleapis#2846](googleapis#2846)) * remove deprecations and update tools-file flag ([googleapis#2806](googleapis#2806)) ### Features * Add a new `enable-api` flag ([googleapis#2846](googleapis#2846)) ([7a070da](googleapis@7a070da)) * **auth:** Add generic `authService` type for MCP ([googleapis#2619](googleapis#2619)) ([f6678f8](googleapis@f6678f8)) * **auth:** Add Protected Resource Metadata endpoint ([googleapis#2698](googleapis#2698)) ([b53dcf2](googleapis@b53dcf2)) * **auth:** Support manual PRM override ([googleapis#2717](googleapis#2717)) ([283e4e3](googleapis@283e4e3)) * **dataplex:** Add support for lookup context tool. ([googleapis#2744](googleapis#2744)) ([facb69d](googleapis@facb69d)) * Remove deprecations and update tools-file flag ([googleapis#2806](googleapis#2806)) ([ab64c95](googleapis@ab64c95)) ### Bug Fixes * **ci:** Remove search index generation from preview deployment workflow ([googleapis#2859](googleapis#2859)) ([f8891b8](googleapis@f8891b8)) * **docs:** Skip empty folders in pagination & reduce PR comment noise ([googleapis#2853](googleapis#2853)) ([9ebd93a](googleapis@9ebd93a)) * **http:** Sanitize non-2xx error output ([googleapis#2654](googleapis#2654)) ([5bef954](googleapis@5bef954)) * **skills:** Fix integer parameter parsing through agent skills ([googleapis#2847](googleapis#2847)) ([4564efe](googleapis@4564efe)) ### Documentation * Release upgraded docsite ([googleapis#2831](googleapis#2831)) ([5b25ce0](googleapis@5b25ce0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> c6b811c

duwenxin99 requested a review from a team as a code owner March 11, 2026 19:27

blunderbuss-gcf Bot assigned Yuan325 Mar 11, 2026

duwenxin99 changed the base branch from main to metadata March 11, 2026 19:27

gemini-code-assist Bot reviewed Mar 11, 2026

View reviewed changes

Comment thread internal/server/mcp.go Outdated

duwenxin99 force-pushed the metadata branch from abd6a92 to e396d82 Compare March 11, 2026 20:57

duwenxin99 force-pushed the prm-flag branch from 387fede to 21ed1e1 Compare March 11, 2026 21:10

duwenxin99 assigned averikitsch and unassigned Yuan325 Mar 11, 2026

averikitsch reviewed Mar 20, 2026

View reviewed changes

Comment thread internal/server/mcp.go Outdated

averikitsch requested changes Mar 20, 2026

View reviewed changes

Comment thread internal/server/mcp.go Outdated

duwenxin99 force-pushed the metadata branch from f1093ba to 6ef476a Compare March 20, 2026 19:17

duwenxin99 force-pushed the prm-flag branch from a08e2e7 to 27ec6f3 Compare March 20, 2026 19:20

duwenxin99 force-pushed the metadata branch 3 times, most recently from 8aafe81 to a6c368b Compare March 23, 2026 19:50

duwenxin99 force-pushed the prm-flag branch from 27ec6f3 to 2f760ec Compare March 23, 2026 22:07

duwenxin99 force-pushed the metadata branch 3 times, most recently from 69ea36f to aea7626 Compare March 25, 2026 20:39

duwenxin99 force-pushed the prm-flag branch 2 times, most recently from b28949b to 2f760ec Compare March 25, 2026 21:58

duwenxin99 force-pushed the prm-flag branch from 2f760ec to 9ba7973 Compare March 25, 2026 22:05

duwenxin99 force-pushed the prm-flag branch from 9ba7973 to 15683a1 Compare March 25, 2026 22:26

duwenxin99 force-pushed the metadata branch from 0c0d39a to c78d11d Compare March 26, 2026 17:57

Base automatically changed from metadata to main March 26, 2026 19:20

rebase

84cc79f

duwenxin99 force-pushed the prm-flag branch from 370a8c8 to 84cc79f Compare March 26, 2026 19:36

duwenxin99 added the release candidate Use label to signal PR should be included in the next release. label Mar 26, 2026

duwenxin99 and others added 2 commits March 26, 2026 15:59

Merge branch 'main' into prm-flag

820dc33

fix lint

2dcc50a

duwenxin99 enabled auto-merge (squash) March 26, 2026 20:00

duwenxin99 merged commit 283e4e3 into main Mar 26, 2026
27 checks passed

duwenxin99 deleted the prm-flag branch March 26, 2026 20:30

github-actions Bot pushed a commit that referenced this pull request Mar 26, 2026

deploy: feat(auth): support manual PRM override (#2717)

a96c1a5

Add flag to allow manual PRM override. 283e4e3

github-actions Bot pushed a commit that referenced this pull request Mar 26, 2026

deploy: feat(auth): support manual PRM override (#2717)

596495a

Add flag to allow manual PRM override. 283e4e3

github-actions Bot pushed a commit to renovate-bot/googleapis-_-genai-toolbox that referenced this pull request Mar 26, 2026

deploy: feat(auth): support manual PRM override (googleapis#2717)

8d8d031

Add flag to allow manual PRM override. 283e4e3

github-actions Bot pushed a commit to renovate-bot/googleapis-_-genai-toolbox that referenced this pull request Mar 26, 2026

deploy: feat(auth): support manual PRM override (googleapis#2717)

64f2fff

Add flag to allow manual PRM override. 283e4e3

release-please Bot mentioned this pull request Mar 26, 2026

chore(main): release 0.31.0 #2814

Merged

BrewTestBot mentioned this pull request Mar 27, 2026

mcp-toolbox 0.31.0 Homebrew/homebrew-core#274467

Merged

Conversation

duwenxin99 commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot commented Mar 11, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

github-actions Bot commented Mar 11, 2026

Uh oh!

github-actions Bot commented Mar 11, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Mar 20, 2026

Uh oh!

github-actions Bot commented Mar 23, 2026

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

github-actions Bot commented Mar 26, 2026

Uh oh!

github-actions Bot commented Mar 26, 2026

Uh oh!

github-actions Bot commented Mar 26, 2026

Uh oh!

Uh oh!

github-actions Bot commented Mar 26, 2026

Uh oh!

github-actions Bot commented Mar 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

duwenxin99 commented Mar 11, 2026 •

edited

Loading