This repository was archived by the owner on Dec 14, 2025. It is now read-only.
Conversation
JustinBeckwith
approved these changes
Sep 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 89.25% 89.34% +0.08%
==========================================
Files 1 1
Lines 121 122 +1
Branches 28 28
==========================================
+ Hits 108 109 +1
Misses 12 12
Partials 1 1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 89.25% 89.34% +0.08%
==========================================
Files 1 1
Lines 121 122 +1
Branches 28 28
==========================================
+ Hits 108 109 +1
Misses 12 12
Partials 1 1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tested with
GOOGLE_APPLICATION_CREDENTIALSset, andgcloudlogged in, we only hit the metadata server IP if these authentication strategies are not found, in which case we will now timeout after3srather than15s.