This repository was archived by the owner on Dec 14, 2025. It is now read-only.
fix: ask gaxios for text and not json#152
Merged
JustinBeckwith merged 1 commit intogoogleapis:masterfrom Jan 15, 2019
JustinBeckwith:txt
Merged
fix: ask gaxios for text and not json#152JustinBeckwith merged 1 commit intogoogleapis:masterfrom JustinBeckwith:txt
JustinBeckwith merged 1 commit intogoogleapis:masterfrom
JustinBeckwith:txt
Conversation
ofrobots
reviewed
Jan 15, 2019
| retryConfig: {noResponseRetries}, | ||
| params: options.params | ||
| params: options.params, | ||
| responseType: 'text' |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ofrobots
approved these changes
Jan 15, 2019
Contributor
ofrobots
left a comment
There was a problem hiding this comment.
Okay, I don't understand how it worked before though. JSON.parse in gaxios of Really Large Numbers should have lost accuracy. It would be worth finding out why that ended up working.
Otherwise, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure why this works today, but I noticed this while making some compatibility fixes in gaxios. I think the intent here was to have
json-bigintalways do theJSON.parseof the response from the metadata server. If that's the case - we should just ask for text from gaxios, since JSON is the default.